Repository navigation
fix: preserve visible text after zero-size PDF fonts - #879
Closed
oscar981-op wants to merge 1 commit into
Closed
oscar981-op wants to merge 1 commit into
oscar981-op wants to merge 1 commit into
Conversation
Merged
Collaborator
|
Thank you, this work is included in v2026.44.6 as 923956a and also in v2026.44.7, which replaces 44.6. It went in as one squashed commit with your authorship, together with other PRs in one integration round, so GitHub does not mark this PR as merged. Closing it for that reason. Changes made during review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PDF whose first text uses a zero-point font can lose all subsequent visible text in PDF.js 6.4.299. Search, selection and Office conversion can consequently see an empty page. This backports Mozilla #22384, commit
d7fd526d5e5176ccd6f066fc6b48d45ee1560af7, into the actual legacy worker shared by the editor and print queue. The existing PostScript progress patch and Chrome 91 worker transformation remain in place; dependency drift fails the build.Office conversion now extracts through a separate strict parser using a copy of the cached source bytes. Unrecoverable extraction errors show an error and write no output. The existing empty-page/image and OCR fallback remains available for valid pages. Source replacement is detected, private parsers are destroyed, and encrypted browser PDFs request the opening password again through the existing dialog (retry/cancel supported; no password retention). Native desktop uses its existing decrypted working copy.
Closes #878.
Validation:
Limitations: strict export reparses the PDF and requires an extra byte-buffer copy. Native installer/WebView and physical Office applications are not locally exercised. Re-authentication is required for encrypted PDFs in the browser. Version
2026.44.24includes the repository-required version updates; no release will be published.Installer status:
release.ymldispatch for this exact branch returned HTTP 422: “Actions has been disabled for this repository”. No installer run was created. An unpublished draft releasev2026.44.24targets exact commit6ff4d49c73d5f03b3cabcd0e89119be01dd9d207; it has no installer assets. No release was published.Upstream CI on exact head
6ff4d49c73d5f03b3cabcd0e89119be01dd9d207: Ubuntu, Windows, render-regression and hosted-CSP passed. The macOS job fails the existingstored definitions stay compact for image watermarkstest (imageDataof undefined), addressed separately by #868; its log was verified. The zero-font regression tests pass. Refresh and retest after that fix is integrated upstream rather than duplicating it here.Required review is outstanding and the contributor account has no upstream merge permission. Keep this PR in draft while installer validation, the baseline macOS failure and review are blocked.