Repository navigation
fix(ribbon): werkende laagkeuze op het tabblad Opmaak (#865) - #867
Draft
oscar981-op wants to merge 1 commit into
Draft
oscar981-op wants to merge 1 commit into
oscar981-op wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #865.
The Format ribbon's Layer dropdown was a static
Noneoption with no change handler. It now reuses the working Layer field from Properties, including markup layers and drawing OCGs, instead of maintaining another assignment path. The ribbon reads the actual selection, shows mixed layers, reacts to layer renames and document changes, and disables the field when drawing, when nothing is selected or when a selected markup is locked.Validation: 14 existing layer checks pass; full unit suite 6182 passed, 19 skipped, 0 failed. TypeScript, Vite build and diff checks pass. A real Chromium/PDF.js regression exercises the ribbon dropdown, single and mixed selection, one-step undo/redo, live rename, locks, empty selection and switching documents. Native Windows/WebKit was not exercised locally. Version 2026.44.17 follows repository policy.
Keep draft pending installer/remote checks and upstream review. The newly merged main also has a platform-dependent large-watermark metadata decoding failure observed in #866's macOS CI. This branch does not change watermark code; the focused fix is in #868 (its macOS unit suite passes). No failing checks should be bypassed.
Remote validation: macOS CI on this head fails in the unchanged large-watermark metadata reader inherited from main. The reproduced cause and regression fix are in #868; that PR passes the macOS unit step. This PR must incorporate the upstream fix and rerun checks before merging.
Installer workflow completed: https://github.com/oscar981-op/open-pdf-studio/actions/runs/40973011375. Android, web and MCPB succeeded. Desktop signing failed: Windows has no Azure signing endpoint; macOS cannot import the certificate; Linux cannot decode the updater private key/password. These are existing fork signing prerequisites and have not been bypassed. The exact-head fork release is still draft. Required review and upstream merge rights are also absent.