-
Notifications
You must be signed in to change notification settings - Fork 43
Steve promises to work on the snippet scanner #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Steve promises to work on the snippet scanner #94
Conversation
Adding a (temporary) trivial change, in order to create the PR. Will update the PR as actual work happens.
Starting a Pull Request for the changes I hope to make in the near future. The plan is to push any work to this PR as its done, so that the work-in-progress is visible. |
errors in the file that need addressing.
summary: Provide URL from which to pull sources for scanning. | ||
operationId: uploadSources | ||
parameters: | ||
- name: purl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to have a location instead of purl?
we might allow a file:// or s3:// or all sorts of locations
schema: | ||
$ref: '#/components/schemas/scanRequestId' | ||
'403': | ||
description: Not authorized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probaly we should add a code for "not accessible" concerning the location
$ref: '#/components/schemas/sourceBundle' | ||
responses: | ||
'200': | ||
description: Successful operation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cocnering the receipt of the code and the request has been queued
content: | ||
application/json: | ||
schema: | ||
$ref: '#/components/schemas/scanRequestId' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should return scanResult. We should add a status in the result so that it could be still "in progress" or "failed"
'403': | ||
description: Not authorized | ||
'405': | ||
description: Validation exception, invalid document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid ID
type: string | ||
matchedComponent: | ||
schema: | ||
$ref: '#/components/schema/purl' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add scanResult:
type: array
properties:
snippetMatch
Adding a (temporary) trivial change, in order to create the PR. Will update the PR as actual work happens.