Repository navigation
fix: broken Makefile continuation lines + benchmark status table - #119
Merged
Merged
Conversation
Three Makefile targets (bench-cluster-split, bench-expert-ablation, bench-selectivity) had missing backslashes on continuation lines, making them fail with "No rule to make target" or shell errors. Also adds a Status column to the BENCHMARKING.md required benchmarks table, marking all implemented benchmarks and adding the two missing entries (expert ablation, multi-class triage). Co-authored-by: OmX <noreply@omx.local>
cschanhniem
force-pushed
the
feat/cluster-split-leakage-test
branch
from
July 1, 2026 01:22
f05ca47 to
1053848
Compare
cschanhniem
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three Makefile targets (
bench-cluster-split,bench-expert-ablation,bench-selectivity) had missing backslashes on continuation lines, making them fail when invoked. Also adds a Status column to the BENCHMARKING.md required benchmarks table and two missing benchmark entries.Changes
bench-cluster-split,bench-expert-ablation,bench-selectivitytargets (missing\at end of line causedmaketo fail)Verification
make bench-cluster-split,make bench-expert-ablation,make bench-selectivityall run successfullyBottleneck class
Repo structure / architecture — broken Makefile targets prevent reproducible benchmark execution, which is a prerequisite for benchmark honesty.
Co-authored-by: OmX noreply@omx.local