Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate created-for node against cmsis-toolbox manifest version #1862

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

spcaipers-arm
Copy link
Collaborator

  • Validate created-for node against cmsis-toolbox manifest version

  • Addressed review feedback

* Validate created-for node against cmsis-toolbox manifest version

* Addressed review feedback
Copy link

github-actions bot commented Nov 21, 2024

Test Results

  7 files   53 suites   4m 32s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit 374463f.

♻️ This comment has been updated with latest results.

@soumeh01 soumeh01 requested a review from brondani November 21, 2024 14:10
@brondani brondani merged commit 5aff765 into Open-CMSIS-Pack:main Nov 21, 2024
101 checks passed
@brondani brondani deleted the outbound/csolutionChk branch November 21, 2024 15:02
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.95%. Comparing base (4570155) to head (374463f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/test/src/ProjMgrUnitTests.cpp 83.33% 0 Missing and 3 partials ⚠️
tools/projmgr/src/ProjMgr.cpp 87.50% 1 Missing and 1 partial ⚠️
tools/projmgr/test/src/ProjMgrTestEnv.cpp 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1862      +/-   ##
==========================================
+ Coverage   64.93%   64.95%   +0.01%     
==========================================
  Files         163      163              
  Lines       34515    34552      +37     
  Branches    20013    20043      +30     
==========================================
+ Hits        22412    22442      +30     
- Misses       7957     7959       +2     
- Partials     4146     4151       +5     
Flag Coverage Δ
buildmgr-cov 73.94% <ø> (ø)
packchk-cov 65.65% <ø> (ø)
packgen-cov 77.87% <ø> (ø)
projmgr-cov 81.69% <81.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgr.cpp 81.14% <87.50%> (+0.13%) ⬆️
tools/projmgr/test/src/ProjMgrTestEnv.cpp 73.56% <50.00%> (-0.56%) ⬇️
tools/projmgr/test/src/ProjMgrUnitTests.cpp 80.99% <83.33%> (+<0.01%) ⬆️
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants