Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDB-11717: UI not responsive when trying to delete a lot of uploaded files from the imports screen #1819

Merged

Conversation

boyan-tonchev
Copy link
Contributor

What

The dialog content overflow is broken.
Steps to reproduce:

  • Add many files for import (20–30);
  • Select all of them;
  • Click on the "Remove" button.

Why

The confirmation dialog in the import view uses the "modal-warning.html" template for confirmation. It is passed to the $uibModal service to open the dialog. This creates a

container with the class "modal-content", which has a display: flex declaration. Its children include three elements with the classes "modal-header", "modal-body", and "modal-footer". The dialog has a max-height of 90vh, and the "modal-body" has CSS rules that make it fit all available height within the dialog. If the content exceeds this height, a scrollbar should appear. Event handling is properly set up and should not cause this issue. However, in this merge request (MR), we added an additional container around these children, which broke the flex functionality.

How

  • The changes made aimed to prevent the right sidebar from closing when clicking on a dialog opened from it (for example, in the cluster view). The additional container had an onClick handler that prevented event propagation, ensuring that clicks on the dialog did not close the sidebar. However, this fix only worked when clicking inside the dialog—clicking outside still closed the sidebar. As a result, I removed this fix;
  • Disabled automatic closing of the sidebar when the user clicks outside the panel;
  • Added the ability to close the sidebar by pressing "Esc".

Testing

N/A

Screenshots

broken
image

Fixed
image

Checklist

  • Branch name
  • Target branch
  • Commit messages
  • Squash commits
  • MR name
  • MR Description
  • [-] Tests

svilenvelikov
svilenvelikov previously approved these changes Feb 13, 2025
…files from the imports screen

## What
The dialog content overflow is broken.
 Steps to reproduce:
  - Add many files for import (20–30);
  - Select all of them;
  - Click on the "Remove" button.

## Why
The confirmation dialog in the import view uses the "modal-warning.html" template for confirmation. It is passed to the $uibModal service to open the dialog.
This creates a <div> container with the class "modal-content", which has a display: flex declaration. Its children include three elements with the classes "modal-header", "modal-body", and "modal-footer". The dialog has a max-height of 90vh, and the "modal-body" has CSS rules that make it fit all available height within the dialog. If the content exceeds this height, a scrollbar should appear. Event handling is properly set up and should not cause this issue. However, [in this merge request (MR)](#1632), we added an additional container around these children, which broke the flex functionality.

## How
- The changes made aimed to prevent the right sidebar from closing when clicking on a dialog opened from it (for example, in the cluster view). The additional container had an onClick handler that prevented event propagation, ensuring that clicks on the dialog did not close the sidebar. However, this fix only worked when clicking inside the dialog—clicking outside still closed the sidebar. As a result, I removed this fix;
- Disabled automatic closing of the sidebar when the user clicks outside the panel;
- Added the ability to close the sidebar by pressing "Esc".
@boyan-tonchev boyan-tonchev force-pushed the GDB-11717-fixes-remove-files-dialog-in-import-view branch from 5e3d040 to b8697b5 Compare February 13, 2025 14:21
@boyan-tonchev boyan-tonchev merged commit d635403 into master Feb 14, 2025
1 check passed
@boyan-tonchev boyan-tonchev deleted the GDB-11717-fixes-remove-files-dialog-in-import-view branch February 14, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants