Skip to content

Conversation

@jinliu9508
Copy link
Contributor

@jinliu9508 jinliu9508 commented Oct 23, 2025

Description

One Line Summary

Create a workflow to automate the Unity release process.

Testing

  • A sample release PR is created by the process in Pull Requests.
  • A draft Release is also created by the automate process.
  • The release unitypackage is verified to be correct compare to the artifact generated by the manual process.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@jinliu9508 jinliu9508 added the WIP label Oct 23, 2025
@jinliu9508 jinliu9508 force-pushed the ci-unity branch 5 times, most recently from db0c30c to f8f965b Compare October 27, 2025 20:12
@jinliu9508 jinliu9508 force-pushed the ci-unity branch 6 times, most recently from a1d62b8 to 397c9a5 Compare October 29, 2025 06:09
@jinliu9508 jinliu9508 force-pushed the ci-unity branch 15 times, most recently from 58fca6c to e0b6002 Compare November 5, 2025 02:13
with:
ref: ${{ needs.prep.outputs.release_branch }}

- name: Configure Git
Copy link
Collaborator

@fadi-george fadi-george Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why isnt this in the update-version job i.e. do these steps before create-release pr job?

echo "$cleaned_notes" >> $GITHUB_ENV
echo "EOF" >> $GITHUB_ENV

- name: Draft Release
Copy link
Collaborator

@fadi-george fadi-george Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe a separate pr action to run after pr is merged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I made them together is that I need to copy release notes generated by the shared action to the CHANGELOG inside the Unity project and commit it before release, which is conflicting because the shared action is for after release. I just moved the release part to a separate workflow.

Copy link

@abdulraqeeb33 abdulraqeeb33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't look at it closely

@jinliu9508 jinliu9508 merged commit 3fc3f90 into main Nov 14, 2025
6 checks passed
@jinliu9508 jinliu9508 deleted the ci-unity branch November 14, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants