Fix: ModalPane never underlap the top of the window or navbar #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @apply rounded-lg border-b-[1px] border-[#C6C6C8] bg-[#F3F2F8] dark:border-[1px] dark:border-[#C6C6C8] dark:border-opacity-15 dark:bg-black; | ||
| } | ||
|
|
||
| .modal-content { | ||
| @apply overflow-y-hidden; | ||
| max-height: calc(100vh - 6.6em); |
aaronbrethorst
requested changes
Sep 4, 2024
There was a problem hiding this comment.
This looks great! I see one change that needs to be made before it can be merged: the contents of the modal pane aren't scrolling as expected, so I can't see any content in the pane that isn't within the viewport.
In the GIF below, the window content moving back and forth is me trying to scroll the stop pane.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
Screenshot:
