Issue 719: Add Custom Region URL #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbrethorst
requested changes
Mar 28, 2024
aaronbrethorst
requested changes
Apr 4, 2024
hilmyveradin
force-pushed
the
issue_719-custom_region_tap_url
branch
from
2a10eaa
to
cd2f73f
Compare
Done, kindly check it out again! |
aaronbrethorst
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Issue #719
Here's a video of working add custom region via URL:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-28.at.20.19.01.mov
Here's a video of manage edge cases, say, when there's no name on the params:
https://github.com/OneBusAway/onebusaway-ios/assets/74521244/ca22596c-a439-4b46-8007-77e9712da02b