Fix #152: Make stop id optional in stop times #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting OBA back to my local OBA
Pulling in from master
…ator when we do this to ensure that there is a start or end service area as defined in the GTFS Flex 1 spec.
…o make sure we don't have stop_times without stop_ids unless they have a start or end service_area
* RTDII-194 throw exception for bad stoptime * ignor iml files * address PR #6 and PR #7 comments * add new test gtfs data * remove iml files * RTDII fix PR#8 comments Co-authored-by: Ray Cha <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Made stop_id optional when reading in stop_times.txt.
Added stop_times validator to StopTime.java
Added call to validator (after GTFS read is complete) to GtfsReader.java
Added until test to verify this behaves as expected.
Expected behavior:
GTFS Modules will behave as expected and still throw an error after reading in the file if a stop_id is null in StopTimes, UNLESS a start_service_area or end_service_area is provided. This is to improve compliance with GTFS Flex v1.
Please make sure these boxes are checked before submitting your pull request - thanks!
mvn testto make sure you didn't break anythingGTFS Flex V1 Support of Null stop_id in stop_time if there is a service area provided #152
@Heidebritta and @sheldonabrown please let me know if you have questions or concerns about this approach.