Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PolicyEnabler mix-in #40
base: develop
Are you sure you want to change the base?
PolicyEnabler mix-in #40
Changes from 3 commits
b91ab4b
61ac6f7
6d57c21
46f3a45
e76051c
e173fb1
6582415
3ec98ae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is can be pulled into all policies - I wonder if it'd be worth reducing bytecode by having a
toggleIsEnabled()
instead of distinct enable and disable functions?The modifier could be also be a single:
Tradeoff with being explicit - so don't mind, just throwing it out there (MonoCooler is kinda chunky which is why i bring up)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that the simplicity would be lost, and it also adds ambiguity.
e.g. the
whenEnabledIs(bool condition)
modifier you shared is reverting ifisEnabled == condition
, but I would have interpreted it the other way -whenEnabledIs(true)
would revert ifisEnabled != true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally fair and agree, thought i'd just throw it in the mix.