feat: ESC key exits node editing and selects the node#9
Merged
OlegIGalkin merged 3 commits intoOlegIGalkin:mainfrom Mar 4, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…copied to out/ The dev config was missing CopyWebpackPlugin, causing out/MindElixir/ to never be created when using bundle-dev or watch. The webview references MindElixir.js from out/MindElixir/, so without the copy step the diagram fails to load. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Pierre-Luc, be mindful that MindElixir might be upgraded to a newer version in the future and this change may be lost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pressing ESC while editing a node now exits editing mode and leaves the node selected.
Changes
VS Code & Visual Studio extensions
MindElixir/MindElixir.js— AddedEscapekey handler in the input boxkeydownlistener. Callst.blur()to save the edit (via the existing blur handler), thenthis.selectNode(e)to ensure the node is explicitly selected and theselectNodeevent fires.VS Code only
webpack.dev.config.js— AddedCopyWebpackPlugin(already present in the production config) soMindElixir.jsis correctly copied toout/MindElixir/when usingbundle-devorwatch. Without this the diagram failed to load in development builds.