Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fx-core): scaffold question and generator refactor #13106

Merged
merged 120 commits into from
Feb 13, 2025
Merged

Conversation

jayzhang
Copy link
Member

@jayzhang jayzhang commented Jan 24, 2025

  1. Clean unused template name and template "copilot-gpt-from-scratch-plugin".
  2. Use mapping between question tree node and template name by data property.
  3. Use mapping between generator and template name in activate function.

TODO: Refactor specGenerator to multiple generators in following PR.

Copy link
Contributor

@HuihuiWu-Microsoft HuihuiWu-Microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes to localized json files later.

@jayzhang jayzhang merged commit 2113c33 into dev Feb 13, 2025
18 of 19 checks passed
@jayzhang jayzhang deleted the nintan/refactor branch February 13, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.