Add trackers for missing block metadata retroactively #2945
+137
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsahee
requested changes
Feb 11, 2025
arbnode/transaction_streamer.go
Outdated
| for start < finish { | ||
| mid := (start + finish + 1) / 2 | ||
| if wasKeyFound(uint64(mid), blockMetadataInputFeedPrefix) || | ||
| wasKeyFound(uint64(mid), missingBlockMetadataInputFeedPrefix) { |
There was a problem hiding this comment.
easier to make wasKeyFound accept just one index and attempt both blockMetadataInputFeedPrefix and missingBlockMetadataInputFeedPrefix
| } | ||
|
|
||
| start := s.trackBlockMetadataFrom | ||
| finish := msgCount - 1 |
There was a problem hiding this comment.
start by checking if there is a value for the first tracked block. This will usually succeed then we can be done with just one database access.
There was a problem hiding this comment.
ahh I had this check after the binary search (since its a required check), will just move this before search
Tristan-Wilson
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, on startup, enables the node to back-fill trackers for missing block metadata when
trackBlockMetadataFromconfig value has moved backwards. We have support for fetching of missing block metadata by first tracking them in arbdb through insertion of keys (trackers) for those block numbers, and fetching usingblock-metadata-fetcher, but in the case if node wants to start tracking from an oldertrackBlockMetadataFromblock number- this PR allows the node to do so.This gives a guarantee that a node will either have all blockMetadata starting from
trackBlockMetadataFromor it is currently trying to fetch the missing ones to rebuild the gaps in blockMetadataResolves NIT-3096