Skip to content

flush batch during chain rewinding, make head rewind block limit configurable #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 30, 2025
Merged

flush batch during chain rewinding, make head rewind block limit configurable #439

merged 5 commits into from
Apr 30, 2025

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Mar 28, 2025 •
edited
Loading

Part of NIT-3198

This PR:

  • adds write batch flushing during chain rewinding - prevents possible panic triggered by batch size exceeding 4GB
  • adds HeadRewindBlocksLimit config option to core.CachingConfig - if set, overwrites default geth rewind limit counted in blocks; geth default is 90000 blocks what e.g. might not be enough for nitro node to reach previously committed state root

@cla-bot cla-bot bot added the s CLA signed label Mar 28, 2025
@magicxyyz magicxyyz changed the title flush batch during chain rewinding flush batch during chain rewinding, make head rewind block limit configurable Apr 28, 2025
@magicxyyz magicxyyz mentioned this pull request Apr 28, 2025
Merged
@magicxyyz magicxyyz marked this pull request as ready for review April 28, 2025 20:34
@joshuacolvin0 joshuacolvin0 merged commit 658e67a into master Apr 30, 2025
15 of 16 checks passed
@joshuacolvin0 joshuacolvin0 deleted the fix-rewinding branch April 30, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoximenes diegoximenes diegoximenes approved these changes

@amsanghi amsanghi Awaiting requested review from amsanghi

Assignees
No one assigned
Labels
design-approved s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicxyyz @diegoximenes @joshuacolvin0