No template op stack script #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d17fded.
TucksonDev
reviewed
Jan 10, 2025
TucksonDev
reviewed
Jan 10, 2025
TucksonDev
reviewed
Jan 10, 2025
yahgwai
approved these changes
Jan 15, 2025
| const toBlock = | ||
| (await this.childChainProvider.getBlockNumber()) - this.blockLag; | ||
| const logs = await this.childChainProvider.getLogs({ | ||
| (await childChainProvider.getBlockNumber()) - this.blockLag; |
There was a problem hiding this comment.
maybe make it max of this or 0, otherwise it might cause problems in test environments?
There was a problem hiding this comment.
good flag, i think the block lag is unnecessary in oneOff mode, so I'll remove it when we get rid of !oneOff mode today or tomorrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested against OP devnode, checkout their monorepo at v1.10.0