Fix New Stake Method #727
Merged
Fix New Stake Method #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing, I'm guessing it's just flaky: https://github.com/OffchainLabs/bold/actions/runs/13143590105/job/36676334983?pr=727#step:6:4874 Speaking of which, it can be in a follow-up PR, but it'd be good to have an automated test of the full addToDeposit delegated stake flow |
|
Great suggestion, I'll work on those next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new stake function was untested, and is important for automating delegated stakers. A boolean was incorrect, and the wrong value was passed into the actual staking mechanism