refactor: allow gas estimation when unconnected #2231
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| ) { | ||
| return { | ||
| status: 'unavailable', | ||
| estimatedParentChainGasFees: undefined, |
There was a problem hiding this comment.
This no longer specifies undefined for this case, just returning estimatedParentChainGasFees as it was.
I checked the UI for native USDC withdrawal from Arb Sepolia to Sepolia and it looks fine
| } | ||
|
|
||
| if ( | ||
| (gasEstimatesError && gasEstimatesError !== 'walletNotConnected') || |
There was a problem hiding this comment.
new condition to bypass 'walletNotConnected'
There was a problem hiding this comment.
encountered this error with import statement of react in import { useDebounce } from '@uidotdev/usehooks'
so we need to configure this and install ts-jest and babel-jest
| 'gasEstimates' | ||
| ] as const) | ||
| : null, | ||
| [ |
There was a problem hiding this comment.
We will need to make a similar change in useOftV2FeeEstmates hook
| @@ -113,5 +109,9 @@ export function useGasEstimates({ | |||
| } | |||
| ) | |||
|
|
|||
| if (typeof walletAddress === 'undefined') { | |||
There was a problem hiding this comment.
Why would we need this error now that we're handling undefined walletAddress?
There was a problem hiding this comment.
Also, if really needed, can this be moved inside the fetcher?
Part of #1452
also added test for
useGasSummary