Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upgrade executor encode function data util #11

Merged
merged 10 commits into from
Dec 15, 2023

Conversation

spsjvc
Copy link
Member

@spsjvc spsjvc commented Dec 14, 2023

Instead of having executeCallEncodeFunctionData it's now more generic so it can be used for any function on UpgradeExecutor.

@spsjvc spsjvc changed the title upgrade executor things feat: upgrade executor function data encoder Dec 14, 2023
@spsjvc spsjvc changed the title feat: upgrade executor function data encoder feat: add upgrade executor encode function data utils Dec 14, 2023
@spsjvc spsjvc marked this pull request as ready for review December 14, 2023 11:23
@spsjvc spsjvc requested a review from fionnachan December 14, 2023 17:16
@spsjvc spsjvc changed the title feat: add upgrade executor encode function data utils feat: add upgrade executor encode function data util Dec 14, 2023
Copy link
Member

@fionnachan fionnachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spsjvc spsjvc merged commit 4a09c4b into main Dec 15, 2023
2 checks passed
@spsjvc spsjvc deleted the upgrade-executor-utils branch December 15, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants