add timeboost troubleshooting guide #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tristan-Wilson
approved these changes
Mar 3, 2025
Tristan-Wilson
requested changes
Mar 3, 2025
TucksonDev
requested changes
Mar 3, 2025
leeederek
commented
Mar 3, 2025
There was a problem hiding this comment.
Thanks @TucksonDev for your review! How do the changes look to you now?
Co-authored-by: José FP <[email protected]>
ganeshvanahalli
requested changes
Mar 21, 2025
There was a problem hiding this comment.
Minor changes requested.
Its better to list all the timeboost related errors to clarify which leads to non-consumption of sequence numbers i.e
- timeboost related error - dont consume
other sequencer returned errorsor nil- consume
Listing timeboost related errors here as well-
- MALFORMED_DATA
- WRONG_CHAIN_ID
- BAD_ROUND_NUMBER
- NO_ONCHAIN_CONTROLLER
- WRONG_AUCTION_CONTRACT
- NOT_EXPRESS_LANE_CONTROLLER
- SEQUENCE_NUMBER_ALREADY_SEEN
- SEQUENCE_NUMBER_TOO_LOW
message sequence number has reached max allowed limit. SequenceNumber: %d, ExpectedSequenceNumber: %d, Limit: %d- error for hitting buffer limit, controller should retry with the ExpectedSequenceNumber in this case
Co-authored-by: Ganesh Vanahalli <[email protected]>
Co-authored-by: Ganesh Vanahalli <[email protected]>
|
Thanks @ganeshvanahalli for the review. I incorporated our suggested fix & also add more information about the error responses. Could I get another review from you? |
Co-authored-by: Ganesh Vanahalli <[email protected]>
Tristan-Wilson
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request adds a troubleshooting guide and best practice recommendations for users of Timeboost following some testing with a few teams trying Timeboost out.
I'd really like to have a separate Timeboost section since we now have docs on: how to use timeboost, troubleshoot timeboost, and its conceptual design. We will have docs on decentralized timeboost eventually as well.