Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in mongodb templates #1570

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fixing bug in mongodb templates #1570

merged 1 commit into from
Oct 29, 2024

Conversation

twerthi
Copy link
Contributor

@twerthi twerthi commented Oct 28, 2024


Background

The latest version of the PowerShell module this template uses requires PowerShell version 7. I've added a check to see if the version is less than 7, then download the version before the requirement was made. This allows older PowerShell workers to continue to work and newer version of PowerShell to work as well.

Results

It will no longer error stating the PowerShell requirements.

Before

The Step Template would fail when trying to import the module for use on clients where PowerShell 5 was the default PowerShell version.

After

It will no longer fail and download the version appropriate to the version of PowerShell being used.

Pre-requisites

  • Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
    • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
  • Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
  • Parameter names should not start with $
  • Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
  • LastModifiedBy field must be present, and (optionally) updated with the correct author
  • The best practices documented here have been applied
  • If a new Category has been created:
    • An image with the name {categoryname}.png must be present under the step-templates/logos folder
    • The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

Fixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line

Copy link

Start Hyponome locally

docker pull ghcr.io/hnrkndrssn/hyponome:main
docker run --rm -p 8000:8080 -it ghcr.io/hnrkndrssn/hyponome:main

Review in Hyponome

@twerthi twerthi merged commit 5430023 into master Oct 29, 2024
3 checks passed
@twerthi twerthi deleted the bug-mongodb branch October 29, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants