Updating oracle create user template #1567
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This template uses the SimplySql PowerShell module. This module had some changes where it implemented named connections to databases. Without specifying the name, it would use default. In the event of an error, the
finally
statement attempted to close the connection. If a failure occurred before a connection was made, thefinally
would also fail and mask the original error.Results
Implemented named connections and updated the
finally
to include a test to see if the connection was open before attempting to close it. Failures are no longer masked if they were caused by the connection attempt itself.Before
If a failure occurred during the connection attempt, the
finally
would attempt to close a connection that didn't exist and mask the original error.After
A test-connection was added to
finally
to see if the connection is open before attempting to close it. Connection attempt errors are no longer masked.Pre-requisites
Id
should be a GUID that is not00000000-0000-0000-0000-000000000000
Id
property (updating theId
will break the Library sync functionality in Octopus).Version
should be incremented, otherwise the integration with Octopus won't update the step template correctly$
LastModifiedBy
field must be present, and (optionally) updated with the correct authorCategory
has been created:{categoryname}.png
must be present under thestep-templates/logos
folderswitch
in thehumanize
function ingulpfile.babel.js
must have acase
statement corresponding to itFixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line