Fix 13 : Create SimpleImputer #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkfitzsimons
requested changes
Dec 13, 2023
|
sorry for this issue , please check now . |
diffprivlib/SimpleImputer
Outdated
|
|
||
| def _impute_mean(self, col, missing_col): | ||
| non_missing_values = col[~missing_col] | ||
| col_mean = np.nanmean(non_missing_values) |
There was a problem hiding this comment.
you are using nanmean from numpy... shouldn't you use the dp version from this library ;)
|
|
||
| def _impute_median(self, col, missing_col): | ||
| non_missing_values = col[~missing_col] | ||
| col_median = np.nanmedian(non_missing_values) |
There was a problem hiding this comment.
you are using nanmedian from numpy... shouldn't you use the dp version from this library ;)
| def _impute_median(self, col, missing_col): | ||
| non_missing_values = col[~missing_col] | ||
| col_median = np.nanmedian(non_missing_values) | ||
| sensitivity = np.nanmax(np.abs(non_missing_values - col_median)) |
There was a problem hiding this comment.
you are using nanmax from numpy... shouldn't you use the dp version from this library ;)
diffprivlib/SimpleImputer
Outdated
| elif self.strategy == 'constant': | ||
| self.statistics_ = [self.fill_value] * X.shape[1] | ||
| else: | ||
| self.statistics_ = [np.nanmean(col) if np.issubdtype(col.dtype, np.number) else np.nan for col in X.T] |
There was a problem hiding this comment.
you are using nanmean from numpy... shouldn't you use the dp version from this library ;)
|
Sorry bhaiya , i think there is no nanmax and nanmedium functions in this lib . Can you please check it once . |
added nan medium and updated bounds in quantile function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.