feat: midas ark by halaprix · Pull Request #629 · OasisDEX/summer-earn-protocol

halaprix · 2025-12-16T13:57:41Z

Description

This PR implements the MidasArk, a new Ark integration for the Summer Earn Protocol that enables yield generation through Midas Protocol vaults.

The implementation follows the ArkWithWithdrawalRequest pattern, handling the specific interactions required for Midas's dual-vault architecture (Issuance Vault for deposits, Redemption Vault for withdrawals) and their mToken share system.

Changes

Added MidasArk.sol: The core contract implementing IArk and inheriting ArkWithWithdrawalRequest.
Implemented board() logic to deposit assets into the Midas Issuance Vault (depositInstant).
Implemented requestWithdrawal() to handle asynchronous redemptions via the Midas Redemption Vault.
Implemented withdrawUsingSwap() to support instant withdrawals via the Redemption Vault's instant redemption mechanism (treated as a swap).
Integrated IMidasOracle for accurate share-to-asset valuation.
Added comprehensive fork tests in MidasArkUSDC.fork.t.sol covering boarding, withdrawals, and value accounting.

Benefits

New Yield Source: Enables users to earn yield from Midas Protocol strategies (e.g., mTBILL/mBASIS) through the Summer Earn interface.
Flexible Exit Options: Supports both standard asynchronous redemptions (primary flow) and instant exits via the "withdraw using swap" mechanism.
Accurate Valuation: Uses Midas's official oracle for precise TVL and share price calculations, ensuring fair value during deposits and withdrawals.

Testing

Fork Tests: Verified against mainnet using MidasArkUSDC.fork.t.sol.
- test_Board_Midas_fork: Verifies deposits into the Issuance Vault.
- test_RequestPartialRedeem_Midas_fork: Verifies queuing of withdrawal requests.
- test_WithdrawUsingSwap_Midas: Verifies instant redemption capabilities.
- test_TotalAssets_UsesOracle: Ensures asset reporting matches oracle rates.

To run tests:
forge test --match-contract MidasArkTestFork

- Implemented the MidasArk contract for managing token supply and yield generation through Midas vaults. - Added interfaces for DepositVault, RedemptionVault, MidasOracle, and MidasWithdrawalManager to facilitate interactions with the Midas protocol. - Created a test suite for MidasArk to validate functionality including asset boarding, withdrawal requests, and total asset calculations using oracle prices. - Established error handling for invalid vault addresses and ensured proper initialization of state variables.

…nstants - Added RequestStatus import to manage redemption request states. - Updated assetsInWithdrawalQueue function to check for pending requests before returning assets. - Refactored requestWithdrawal function to prevent multiple withdrawal requests. - Introduced MIDAS_ROUNDING_OFFSET constant for slippage calculations. - Added internal functions for validating board and disembark data, ensuring no additional parameters are required.

…e-core subproject status - Removed the console log statement for shares calculation in MidasArk test to clean up output. - Updated pendle-core subproject commit to indicate a dirty state, reflecting local changes.

…ality - Updated import statements for clarity and added necessary interfaces. - Refactored state variables into distinct sections for better organization. - Improved asset calculation methods by introducing internal functions for shares to assets conversion. - Enhanced withdrawal logic to streamline request handling and ensure accurate asset retrieval. - Removed redundant code and comments to improve readability and maintainability.

coderabbitai · 2025-12-16T13:57:51Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch kk/midas-ark

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

- Removed unnecessary comment regarding total shares calculation in MidasArk contract to enhance code clarity and maintainability. - Updated pendle-core subproject status to reflect a dirty state, indicating local modifications.

robercano

Looks great! I've gone very specific to iterate on our best practices and have a discussion about what we want to do in the code. Also, what's the plan for the test TODOs?

robercano · 2025-12-16T14:35:22Z

+
+import {SafeERC20} from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";
+
+error InvalidIssuanceVault();


Chain Security audit pointed out that errors should be defined in a separate file. It is also my preference. What do you think about it?

robercano · 2025-12-16T14:36:11Z

+     * @notice 100 percent with base 100
+     * @dev for example, 10% will be (10 * 100)%
+     */
+    uint256 public constant ONE_HUNDRED_PERCENT = 100 * 100;


Is this Midas specific? Or could we use Percentage instead? If Percentage cannot be used I'd add a comment here explaining why

it's midas specific

robercano · 2025-12-16T14:36:43Z

+     * @notice Default slippage for the swap
+     * @dev 50 is 50% (50/10000)
+     */
+    uint256 public constant DEFAULT_SLIPPAGE = 50;


Same reasoning for slippage as for the hundrer percent, can we use Percent?

it's alredy done this way in the base contract - let's keep the changes for another PR

robercano · 2025-12-16T14:38:06Z

+
+        // Verify mToken matches vaults
+        IMToken issuanceVaultMToken = issuanceVault.mToken();
+        if (address(issuanceVaultMToken) != _mToken)


This makes me wonder if we really need to pass the _mToken parameter or just fetch it from the protocol and that's it. Why are we passing _mToken?

yeah correct. That's been changed

robercano · 2025-12-16T14:38:19Z

+        if (address(issuanceVaultMToken) != _mToken)
+            revert InvalidMTokenAddress();
+
+        IMToken redemptionVaultMToken = redemptionVault.mToken();


Same reasoning here

robercano · 2025-12-16T14:51:00Z

+     */
+    function setMaxSupplyCap(uint256 newValue) external;
+
+    function tokensConfig(


Can we document these functions, even if it is to say that there is nothing to document? It stands out when reading the interface

robercano · 2025-12-16T14:51:14Z

+        address token
+    ) external view returns (TokenConfig memory);
+
+    function mTokenDataFeed() external view returns (address);


robercano · 2025-12-16T14:52:05Z

+    bool stable;
+}
+
+enum RequestStatus {


Documentation for enum, and the next three structs? Or is this copied from Midas and they didn't document it? If so, please add a comment at the top mentioning this, so auditors will know why

robercano · 2025-12-16T14:52:18Z

+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.0;
+
+interface IMidasOracle {


robercano · 2025-12-16T14:52:46Z

+// SPDX-License-Identifier: MIT
+pragma solidity 0.8.28;
+
+interface IMidasWithdrawalManager {


And here? (just marking the places where this may be needed)

- Added HyperBeatCoreArk contract to facilitate integration with the HyperBeatCore protocol. - Implemented MidasArk contract for managing Midas protocol interactions. - Created interfaces for HyperBeat components including IHyperBeatDepositor, IHyperBeatOracle, IHyperBeatPricer, and IHyperBeatVaultToken. - Updated deployment scripts and configuration files to support new ark types and their parameters. - Enhanced test coverage for the new contracts and their functionalities.

…asArk contracts - Introduced custom error interfaces IHyperBeatCoreArkErrors and IMidasArkErrors for better error management. - Replaced existing revert statements with specific error calls in HyperBeatCoreArk and MidasArk constructors. - Enhanced clarity and maintainability of error handling in both contracts. - Updated documentation for withdrawal functions to clarify special withdrawal conditions.

…asArk contracts - Added clarifying comments regarding the handling of token decimals in the conversion factor calculations. - Specified that vault tokens and mTokens are expected to have 18 decimals, and noted the rarity of assets with more than 18 decimals in the context of these contracts.

- Introduced MidasArk contract for managing token supply and yield generation through Midas vaults. - Updated deployment configurations to include MidasArk with USDC asset and associated parameters. - Enhanced deployment artifacts and journal entries to reflect the new MidasArk integration.

- Added checks in MidasArk to ensure payment tokens are stable and have no associated fees. - Introduced a new error for invalid token configurations in IMidasArkErrors. - Updated IDepositVault and IRedemptionVault interfaces to include tokensConfig function documentation. - Modified deployment configurations for improved clarity and consistency.

halaprix added 4 commits December 16, 2025 12:08

halaprix changed the title ~~Kk/midas-ark~~ feat: midas ark Dec 16, 2025

halaprix and others added 2 commits December 16, 2025 15:01

Update Codecov badge to current branch

c2a8af8

robercano requested changes Dec 16, 2025

View reviewed changes

halaprix added 6 commits January 19, 2026 21:13

Merge branch 'main' into kk/midas-ark

5ee6018


		import {SafeERC20} from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";

		error InvalidIssuanceVault();

Conversation

halaprix commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Benefits

Testing

Uh oh!

coderabbitai Bot commented Dec 16, 2025

Review skipped

Uh oh!

robercano left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

halaprix commented Dec 16, 2025 •

edited

Loading