Open
Conversation
Contributor
adamskrodzki
left a comment
adamskrodzki
left a comment
There was a problem hiding this comment.
Looks ok, commented only on refactoring.
I'm missing clear test failing before and passing after
contracts/multiply/Exchange.sol
Outdated
| } | ||
|
|
||
| function _collectFee(address asset, uint256 fromAmount) internal returns (uint256) { | ||
| function _collectFeeTokenToDai(address asset, uint256 fromAmount) internal returns (uint256) { |
Contributor
There was a problem hiding this comment.
since "asset" is allways DAI_ADDRESS in both invocation maybe it will be clearer to remove asset parameter
Contributor
Author
What do you mean by that? |
adamskrodzki
approved these changes
Nov 15, 2021
peculiarity
force-pushed
the
gg/fix-exchange-fee-collection
branch
from
f3ef0fb to
e745d4a
Compare
peculiarity
force-pushed
the
gg/fix-exchange-fee-collection
branch
from
e745d4a to
af3ae9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.