Draft
Conversation
rkrasiuk
reviewed
Feb 2, 2022
Comment on lines
+24
to
+25
| manager = _manager; | ||
| exchange = _exchange; |
Contributor
There was a problem hiding this comment.
isn't it better to move this to service registry?
Comment on lines
+5
to
+17
| struct CdpData { | ||
| address gemJoin; | ||
| address payable fundsReceiver; | ||
| uint256 cdpId; | ||
| bytes32 ilk; | ||
| uint256 requiredDebt; | ||
| uint256 borrowCollateral; | ||
| uint256 withdrawCollateral; | ||
| uint256 withdrawDai; | ||
| uint256 depositDai; | ||
| uint256 depositCollateral; | ||
| bool skipFL; | ||
| string methodName; |
Contributor
There was a problem hiding this comment.
are we sticking with this struct? it has an abundance of unnecessary fields. could we maybe break it out into CloseCDPData, OpenCDPData etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is alternative approach How to use FlashLoans cleanly
Every business operation (OpenMultiply, Increase,Decreas, CloseToDai, CloseToCollateral, OpenGUNI, etc)
Has it's own Action contract which adress is stored in service registry,
Each Action contract iherits from BaseAction and therefore implements 4 methods:
then to call an action
You call one central contract call runner (as delegateCall on dsProxy)
function executeAction(string calldata actionName, bytes calldata actionData)depending on action implementation FL is called or not,