Skip to content

Conversation

@emmacarli
Copy link
Contributor

@emmacarli emmacarli commented Jan 22, 2025

No error raising inlist_graphqlmeant that if a Seqera MeerPipe job failed at the OBS_LIST stage, it could be recorded as completed. So I added error raising there.
I though I'd add it everywhere else too but not sure if that's going to cause unnecessary/numerous job fails if some errors should stay silent. Can modify if that happens.

@emmacarli
Copy link
Contributor Author

I just saw issue #2 . Does this solve it or is it more subtle and I should undo my edits on parse_mutation_response ?

@NickSwainston
Copy link
Collaborator

This looks correct, but I don't have the memory of the code flow to be sure. My main recommendation is to test it with your wifi, run a psrdb command, and then run echo $? and confirm it is a non-zero number. The non-zero error codes should be all you need to cause other pipeline jobs to fail correctly (which is a weird sentence)

@emmacarli
Copy link
Contributor Author

Need to add (if not already done), a check for the word "error" in the response (e.g. template_response.text ) could be \n<h3>Internal Server Error</h3>\n but the status would still be 200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants