Skip to content

allowAttributes("style").globally() shouldn't imply allowStyling() - Regression with 2024 version #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

allowAttributes("style").globally() shouldn't imply allowStyling() - Regression with 2024 version #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
741ed90
Fix : allowAttributes("style").globally() shouldn't imply allowStyling()
subbudvk Apr 11, 2024
cf0fa25
Fix : Test related to global stylinh
subbudvk Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions owasp-java-html-sanitizer/src/main/java/org/owasp/html/HtmlPolicyBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,9 +967,6 @@ public AttributeBuilder matching(
*/
@SuppressWarnings("synthetic-access")
public HtmlPolicyBuilder globally() {
if (attributeNames.contains("style")) {
allowStyling();
}
return HtmlPolicyBuilder.this.allowAttributesGlobally(
policy, attributeNames);
}
Expand Down
11 changes: 0 additions & 11 deletions owasp-java-html-sanitizer/src/test/java/org/owasp/html/SanitizersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,17 +541,6 @@ public static final void testOptionAllowsText() {
pf.sanitize(input)
);
}

@Test
public static final void testStyleGlobally() {
PolicyFactory policyBuilder = new HtmlPolicyBuilder()
.allowAttributes("style").globally()
.allowElements("a", "label", "h1", "h2", "h3", "h4", "h5", "h6")
.toFactory();
String input = "<h1 style=\"color:green ;name:user ;\">This is some green text</h1>";
String want = "<h1 style=\"color:green\">This is some green text</h1>";
assertEquals(want, policyBuilder.sanitize(input));
}

static int fac(int n) {
int ifac = 1;
Expand Down