Repository navigation
feat(comprehension): ingestion-time LLM digests so ask/chat answer structure + combination questions - #1158
Draft
northdpole wants to merge 3 commits into
Draft
feat(comprehension): ingestion-time LLM digests so ask/chat answer structure + combination questions#1158northdpole wants to merge 3 commits into
northdpole wants to merge 3 commits into
Conversation
…es at ingestion Replace hand-curated structural facts with LLM comprehension of harvested standards. Per-document claims must carry a verbatim quote found in the source; a per-standard overview must cite existing documents. Results are embedded as evidence docs in the existing agent channel; at query time the router synthesizes an answer from the top comprehension hits and strips uncited output (UNKNOWN falls through). - application/utils/comprehension: sources, digest, store, synthesize, answer - scripts/comprehend_standard.py: run for one harvested repo - router hook behind OWASP_COMPREHENSION_ENABLED (default on) - design note: docs/oie/comprehension-design.md Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…, prefer latest version, overview-first ordering Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1155.
Why
#1155 answered structural questions (e.g. SAMM levels) from hand-written facts, which cannot scale and was partly wrong. This derives that knowledge at ingestion instead.
How
application/utils/comprehension/: reads whole harvested documents, extracts claims that must include a verbatim quote found in the source (unverified claims dropped), builds a per-standard overview that must cite existing documents, and stores everything as embedded evidence docs in the existing agent channel.UNKNOWNfalls through to existing paths. Flag:OWASP_COMPREHENSION_ENABLED(default on).scripts/comprehend_standard.py --repo OWASP/SAMMruns it per harvested repo.docs/oie/comprehension-design.md.Verified on staging (homeserver)
SAMM/ASVS/MASVS/AI guide digested; e.g. "how many levels in owasp samm" returns three maturity levels per practice (also surfaces a v1.5 vs v2 conflict, to fix by preferring the latest version), with GitHub citations.
Not done yet
Generated source-grounded eval (Gemini questions, Claude judge), held-out standard test, version preference, removal of hand-written
node_facts, people/talks layer, scheduling into the pipeline.🤖 Generated with Claude Code