-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup: removing unused dependencies n dev dependencies #601
Cleanup: removing unused dependencies n dev dependencies #601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shining-bluemoon-11 thanks for taking care of this!
Could you resolve the conflicts?
@arkid15r yes , i can try to resolve the conflicts , can you give the direction here |
![]() I suggest resolving |
@arkid15r , need your help here |
I've resolved the conflicts. Please check that dependencies look good to you and I'll review it after that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems something used was removed
@arkid15r }; <---- these are few more unused dependencies that should also be removed but are there |
06f791f
to
b91af23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you resolve the conflicts and remove unrelated code?
Ya , I am working on it. I apologize for the delay, but I will do it. |
@shining-bluemoon-11 Hi! Is this PR ready for review? I see one failing check, so I'm not sure if you are still working on it! |
@aramattamara , |
@arkid15r , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove unrelated files from the PR?
I believe you should keep frontend package JSON files only.
@arkid15r done , removed the unwanted files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let's try this!
@arkid15r , |
* "Cleanup: removing unused dependencies n dev dependencies " * resolved conflicts * Fix staging image build * "Cleanup: removing unused dependencies n dev dependencies " * fix run npm install install prettier plugin tailwindcss * fix run run npm lint check * fix check for uncommited changes * resolved conflicts n npm format check * "Cleanup: removing unused dependencies n dev dependencies " * resolved conflicts * Fix staging image build * "Cleanup: removing unused dependencies n dev dependencies " * fix run npm install install prettier plugin tailwindcss * fix run run npm lint check * fix check for uncommited changes * resolved conflicts n npm format check * updated one * updated fix * removed unwanted files from updated fix * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]>
* anchor tags migrated * Buttons migrated to chakraUI * migarted buttons tooltip and anchortags to chakraUI * fixed focus ring issue * Generic component for details page (#678) * base_design * Add types and apply corrections. * Improvement * cleanup * added issue label * fixes * pre-commit --------- Co-authored-by: Kate Golovanova <[email protected]> * Addition of Contribute Section in Home of Slack NestBot (#593) * Addition of Contribute Section in Home of Slack NestBot * Update contribute.py * Update of apps/slack/commands/contribute * Minor changes * Update of code after the review * Update backend/apps/slack/commands/contribute.py Co-authored-by: Nitin Awari <[email protected]> * Update urls.py * Update contribute.py * Update code --------- Co-authored-by: Nitin Awari <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> * resolved conflicts * sort dropdown tooltip position modified * test utils warpper used * checks and format * removed unnecessary button props * removed redundant lines * Update FE dependencies * tooltip-bug (#744) * Addition of website attribute to project schema (#740) * Addition of website attribute to project schema * Update vite.config.ts * Update website-empty.yaml * Update website-none.yaml * Update website-none.yaml * Update website-empty.yaml * Update website-none.yaml * Update website-empty.yaml * Update website-empty.yaml * Update project_test.py * Update project.json * Delete schema/tests/data/project/negative/website-empty.yaml * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> * Add blog to project schema (#745) * added blog attribute to project schema * added blog attribute * Update project_test.py * Update code * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> * Initialize OWASP chapter schema * Refactor index synonyms (#748) * Changes5 * Refactor index synonyms * Update code --------- Co-authored-by: Raghav Gupta 2 <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> * write repository schema and tests (#741) * write repository schema and tests * fixed repository schema tests * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> * Fetch /gsoc command data from Algolia instead of DB (#712) * gsoc command data fetch from algolia * pre-commit and format checks * moved get_gsoc_projects to search project file * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> * Reconfigure spell check * Bump @chakra-ui/react from 3.6.0 to 3.7.0 in /frontend (#752) Bumps [@chakra-ui/react](https://github.com/chakra-ui/chakra-ui/tree/HEAD/packages/react) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/chakra-ui/chakra-ui/releases) - [Changelog](https://github.com/chakra-ui/chakra-ui/blob/main/packages/react/CHANGELOG.md) - [Commits](https://github.com/chakra-ui/chakra-ui/commits/@chakra-ui/[email protected]/packages/react) --- updated-dependencies: - dependency-name: "@chakra-ui/react" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update params mapping * Added a method to convert block to text and fixed warning (#754) * Added a method to convert block to text * Added testcase for utils * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> * Update frontend dependencies * Run poetry update * conflicts resolved * Cleanup: removing unused dependencies n dev dependencies (#601) * "Cleanup: removing unused dependencies n dev dependencies " * resolved conflicts * Fix staging image build * "Cleanup: removing unused dependencies n dev dependencies " * fix run npm install install prettier plugin tailwindcss * fix run run npm lint check * fix check for uncommited changes * resolved conflicts n npm format check * "Cleanup: removing unused dependencies n dev dependencies " * resolved conflicts * Fix staging image build * "Cleanup: removing unused dependencies n dev dependencies " * fix run npm install install prettier plugin tailwindcss * fix run run npm lint check * fix check for uncommited changes * resolved conflicts n npm format check * updated one * updated fix * removed unwanted files from updated fix * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kate Golovanova <[email protected]> Co-authored-by: Raj gupta <[email protected]> Co-authored-by: AbhayTopno <[email protected]> Co-authored-by: Nitin Awari <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: yashgoyal0110 <[email protected]> Co-authored-by: Rusheek <[email protected]> Co-authored-by: Raghavg18 <[email protected]> Co-authored-by: Raghav Gupta 2 <[email protected]> Co-authored-by: Shyam Kumar <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Abhay <[email protected]> Co-authored-by: Diamond Girl <[email protected]>
Remove Unused Dependencies
RESOLVES #578
This PR removes unused dependencies from the project.
Removed:
{
Updated package.json and package-lock.json accordingly
This change aims to: