Route docker_scanner error/troubleshooting output through docksec.output#125
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up cleanup: docker_scanner.py's Hadolint/Trivy/Docker Scout error and
troubleshooting messages used raw print() instead of the docksec.output layer used
everywhere else in the tool, so they didn't honor --quiet/--no-color/--json.
Changes
ui.detail() for troubleshooting steps.
legacy text-scan timeout/error paths: print() -> ui.error().
debug entry point) untouched - it's not part of the real docksec CLI and was out of
scope for this cleanup.
Testing
change).
and --compose scans.