Phase 3: add --baseline/--update-baseline ratchet mode#124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds baseline/ratchet mode so
--fail-oncan be adopted on existing projects withoutpre-existing findings blocking every build - a gap identified against the cve-lite-cli
UX/feature benchmark.
Changes
--baseline FILE: path to a baseline file. Combined with--fail-on, only findings notalready present in the baseline trigger the gate.
--update-baseline: writes the current scan's findings to--baselineinstead ofgating. Requires
--baseline(exits 2 otherwise).docksec/baseline.py: fingerprints findings byVulnerabilityID|Target|PkgName(stable across scans of the same Dockerfile/image/compose file), and provides
load/save/diff helpers.
--fail-on --baselinerun against afile that doesn't exist yet behaves like no
--baselineat all, until--update-baselineis run once.Testing
ruff check .passes.pytest: 157 passed (+16: baseline module unit tests, CLI wiring/gate integration tests).--update-baselinewrites a valid baseline file and does not gate;a baselined finding no longer trips
--fail-on; a new finding still trips it; missing--baselinewith--update-baselineexits 2.