-
Notifications
You must be signed in to change notification settings - Fork 0
add contributors to team commits #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Please confirm the following:
|
50427f6
to
3254244
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entry for Elke has 'fomer' instead of 'former'
Thanks, I'll fix that typo on full Team listing. BTW, this ticket was just to bring over the items from git history contribs. Full Team contributions are reflected on the www page you mentioned Mike. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Olga Kuchar should be on the list.
@pwidene Initial thinking was just to take git log output and for this pr, and use www page for full Team listing. In part b/c i did not know if everyone had github id's. On further reflection, thinking we just use name/email address and if align w/ github id then "good enough" if not align or no-github-id, then still no harm. Sound good? |
3254244
to
de4ca27
Compare
@naughtont3 Olga is probably not on any git commit for the ORNL gitlab repo. However she did create content which was in the original Word version of the SOS spec that predated our use of gitlab, and which has persisted through to what we're showing publicly. I'm fine whatever attribution scheme y'all are coming up with, just wanted to note this. |
@pwidene Yes, totally agree. I have added Olga to this msg. Will not have effect of adding to github contributors list, but i think that its better. Thanks and good suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTM
de4ca27
to
105c529
Compare
This change is intended to bring the rest of the team into the GitHub history. We exported the old repo and started with a clean git history when moving to GitHub. These attributions should have been on the initial commit. Co-authored-by: Elke Arenholz <no-reply> Co-authored-by: Scott Atchley <[email protected]> Co-authored-by: Swen Boehm <[email protected]> Co-authored-by: Michael J. Brim <[email protected]> Co-authored-by: Christian Engelmann <[email protected]> Co-authored-by: Olga Kuchar <[email protected]> Co-authored-by: Jack Lange <[email protected]> Co-authored-by: Marshall McDonnell <[email protected]> Co-authored-by: Ben Mintz <[email protected]> Co-authored-by: Rob Moore <[email protected]> Co-authored-by: Thomas Naughton <[email protected]> Co-authored-by: Suhas Somnath <ssomnath@no-reply> Co-authored-by: Rohit Srivastava <[email protected]> Co-authored-by: Patrick Widener <[email protected]> Signed-off-by: Thomas Naughton <[email protected]>
105c529
to
bae14c2
Compare
Thanks for all response. I've decided to go the route of including |
For past reviews: added olga (@pwidene) fixed typos in 9ed643c (@MichaelBrim). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change is mainly intended to bring the rest of the team into the Git history.
We exported the old repo and started with a clean git history when moving to GitHub.
These attributions should have been on the initial commit.