Skip to content

add contributors to team commits #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

naughtont3
Copy link
Contributor

This change is mainly intended to bring the rest of the team into the Git history.
We exported the old repo and started with a clean git history when moving to GitHub.
These attributions should have been on the initial commit.

@naughtont3
Copy link
Contributor Author

naughtont3 commented Oct 11, 2024

Please confirm the following:

  1. Your email is correct to map to GitHub username
    *. Confirm ok with including your email in public git history (if rather, can put xxx@no-reply)
  2. Name appears correctly (no misspellings, etc.)

@naughtont3 naughtont3 force-pushed the team-coauthorby-msg branch 3 times, most recently from 50427f6 to 3254244 Compare October 11, 2024 14:46
Copy link
Contributor

@MichaelBrim MichaelBrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry for Elke has 'fomer' instead of 'former'

@naughtont3
Copy link
Contributor Author

Thanks, I'll fix that typo on full Team listing. BTW, this ticket was just to bring over the items from git history contribs. Full Team contributions are reflected on the www page you mentioned Mike.

@pwidene pwidene self-requested a review October 11, 2024 15:36
Copy link
Contributor

@pwidene pwidene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olga Kuchar should be on the list.

@naughtont3
Copy link
Contributor Author

Olga Kuchar should be on the list.

@pwidene Initial thinking was just to take git log output and for this pr, and use www page for full Team listing. In part b/c i did not know if everyone had github id's. On further reflection, thinking we just use name/email address and if align w/ github id then "good enough" if not align or no-github-id, then still no harm. Sound good?

@pwidene
Copy link
Contributor

pwidene commented Oct 11, 2024

@naughtont3 Olga is probably not on any git commit for the ORNL gitlab repo. However she did create content which was in the original Word version of the SOS spec that predated our use of gitlab, and which has persisted through to what we're showing publicly. I'm fine whatever attribution scheme y'all are coming up with, just wanted to note this.

@naughtont3
Copy link
Contributor Author

@pwidene Yes, totally agree. I have added Olga to this msg. Will not have effect of adding to github contributors list, but i think that its better. Thanks and good suggestion.

Copy link

@boehms boehms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM

This change is intended to bring the rest of the team into
the GitHub history.

We exported the old repo and started with a clean git history
when moving to GitHub.

These attributions should have been on the initial commit.

Co-authored-by: Elke Arenholz <no-reply>
Co-authored-by: Scott Atchley <[email protected]>
Co-authored-by: Swen Boehm <[email protected]>
Co-authored-by: Michael J. Brim <[email protected]>
Co-authored-by: Christian Engelmann <[email protected]>
Co-authored-by: Olga Kuchar <[email protected]>
Co-authored-by: Jack Lange <[email protected]>
Co-authored-by: Marshall McDonnell <[email protected]>
Co-authored-by: Ben Mintz <[email protected]>
Co-authored-by: Rob Moore <[email protected]>
Co-authored-by: Thomas Naughton <[email protected]>
Co-authored-by: Suhas Somnath <ssomnath@no-reply>
Co-authored-by: Rohit Srivastava <[email protected]>
Co-authored-by: Patrick Widener <[email protected]>
Signed-off-by: Thomas Naughton <[email protected]>
@naughtont3
Copy link
Contributor Author

Thanks for all response. I've decided to go the route of including @ornl.gov addresses and extending the list to all from the Team www view. All emails that are included here are also visible on webpages at ornl, so do not feel there's a problem with adding them. I'll let this sit to next week in case there are any objections and then click the clicks.

@naughtont3
Copy link
Contributor Author

For past reviews: added olga (@pwidene) fixed typos in 9ed643c (@MichaelBrim).

Copy link
Contributor

@pwidene pwidene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants