feat: fix brightness filter implementation for proper GCC compatibility #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@saumya1317 Resolve the conflict and validate the commit |
harshsankhla18
merged commit fb2260f
into
OPCODE-Open-Spring-Fest:main
0 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the brightness filter implementation to work correctly with GCC and proper argument parsing. The previous implementation had flawed argument parsing logic that prevented the brightness filter from functioning properly.
Key fixes:
Corrected getopt() usage with proper while loop and optarg handling
Fixed filters string to include vignette support ("bgrsivB:")
Updated brightness value parsing to use standard optarg instead of manual argv parsing
Added missing vignette filter case in switch statement
Fixed loop counter to use actual parsed filter count
The brightness filter now works correctly with the usage format: ./filter -B 40 input.bmp output.bmp
Semver Changes
[ ] Patch (bug fix, no new features)
[x] Minor (new features, no breaking changes)
[ ] Major (breaking changes)
Issues
Closes #17
Checklist
[x] I have read the Contributing Guidelines.