-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Server] Restore durable subscriptions on Server Restart #3025
Open
romanett
wants to merge
19
commits into
OPCFoundation:master
Choose a base branch
from
romanett:restoreSubscriptions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Server] Durable Subscriptions (OPCFoundation#2683) * Implement a system test for DurableSubscriptions (OPCFoundation#2839) * Client Side Co-authored-by: ALTERNATE-DEV\Archie <[email protected]>
Use NodeIdDictionary where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR Enables the Server to persist existing durable subscriptions (incl message queue) on a server shutdown (incl. MonitoredItems & event / datatchange queues). And restore them after a server restart.
The persisting is done by extending
Subscription
&MonitoredItem
with a method that converts the internal state of the object into a format that can be json serialized.For this Subscription has a new Method
public IStoredSubscription ToStorableSubscription()
.The IMonitoredItem interface is extended with a new Method
IStoredMonitoredItem ToStorableMonitoredItem()
.Both Subscription & Monitoreditem have a new constructor accepting an
IStoredSubscription
/IStoredMonitoredItem
.The
MasterNodeManager
has a new MethodAlso
INodeManager
is extended with a new MethodThose methods are only called (& need to be implemented) if durable subscriptions will be supported by the server.
They will be called by the
SubscriptionManager
on Startup if subscriptions to restore a found.The
SubscriptionManager
has access to an InterfaceISubscriptionStore
that is registered globally in the server.The Interface has methods for Storing & Restoring Subscriptions & providing access to durable queues after a restart.
In the reference server the
SubscriptionStore
impementation communicates with theIMonitoredItemQueueManager
to store & restore durable queues.On Shutdown the
SubscriptionManager
will initate the storing process if anISubscriptionStore
is registered & durable subscriptions are enabled & present on the server.In the reference server the serializable objects are written into a file in the current exectuting directory.
Types of changes
Checklist
Further comments
Open Issues: