-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Add ECC Certificates to various tests #2961
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2961 +/- ##
==========================================
+ Coverage 55.40% 55.53% +0.12%
==========================================
Files 352 352
Lines 67859 67856 -3
Branches 13908 13905 -3
==========================================
+ Hits 37598 37684 +86
+ Misses 26136 26062 -74
+ Partials 4125 4110 -15 ☔ View full report in Codecov by Sentry. |
@@ -257,10 +257,9 @@ public virtual async Task UpdateCertificateAsync(SecurityConfiguration securityC | |||
|
|||
try | |||
{ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the rational for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The certificate identifier is already updated before calling the Update Method of the certificate validator. So the Check is not deleting the old cert from m_applicationCertificates this can lead to memory leaks or exceptions If find is not called on the certificate identifier before trying to Access RawData
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The m_appliction certificates list is rebuilt in the UpdateAsync method
…s ECDSA_P384 instead of nistP384
Proposed changes
Related Issues
Types of changes
Checklist
Further comments