detect: set mpm/prefilter during signature parsing #12382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12382 +/- ##
==========================================
- Coverage 82.46% 80.49% -1.98%
==========================================
Files 914 917 +3
Lines 258316 258652 +336
==========================================
- Hits 213030 208207 -4823
- Misses 45286 50445 +5159
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 24191 |
|
Just a cleanup, no ticket. |
catenacyber
reviewed
Jan 14, 2025
| @@ -551,6 +551,9 @@ typedef struct SignatureInitData_ { | |||
| bool src_contains_negation; | |||
| bool dst_contains_negation; | |||
|
|
|||
| /** see if any of the sigmatches supports an enabled prefilter */ | |||
There was a problem hiding this comment.
only used in debug logging ?
There was a problem hiding this comment.
Should it be under #ifdef ? Or used in some other place ? or just removed as a development artifact ?
catenacyber
reviewed
Jan 14, 2025
|
Besides one nit question, lgtm |
In preparation of flowbit prefilter work that needs this info earlier. Track potential prefilter sm's to avoid unnecessary looping during setup.
victorjulien
force-pushed
the
prefilter-cleanup/v1
branch
from
363e1a2 to
bd3e65b
Compare
|
Information: QA ran without warnings. Pipeline 24218 |
|
The variable is now used. Rebased in #12418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of flowbit prefilter work that needs this info earlier.
Track potential prefilter sm's to avoid unnecessary looping during setup.