Flow bytes pkts syntax/v9 #12353
Open
Flow bytes pkts syntax/v9 #12353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the syntax includes direction as a part of the keyword which is against how usually keywords are done. By making direction as a mandatory argument, it is possible to make the syntax cleaner and the implementation more compact and easily extendable. Pros: - Registration table sees lesser entries if newer options are added - If the options have to be extended, it can be done trivially - In accordance w existing keyword implementations Note that this commit also retains the existing direction specific keywords.
For flow.bytes and flow.pkts keywords, allow matching in either direction. Feature 5646
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12353 +/- ##
==========================================
+ Coverage 83.23% 83.24% +0.01%
==========================================
Files 912 912
Lines 257647 257790 +143
==========================================
+ Hits 214450 214610 +160
+ Misses 43197 43180 -17
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
requested changes
Jan 8, 2025
| return 0; | ||
| DetectU32Data *du32 = DetectU32Parse(pkt_data); | ||
| if (du32 == NULL) | ||
| goto error; |
| df->pkt_data = du32; | ||
| if (SigMatchAppendSMToList( | ||
| de_ctx, s, DETECT_FLOW_PKTS, (SigMatchCtx *)df, DETECT_SM_LIST_MATCH) == NULL) { | ||
| goto error; |
There was a problem hiding this comment.
DetectFlowPktsFree(de_ctx, df);
return -1;These 2 changes allow us to avoid the goto pattern w/o drawbacks?
There was a problem hiding this comment.
ah I see DetectFlowBytesSetup does it this way as well
|
Information: QA ran without warnings. Pipeline 24111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #12340
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/5646
SV_BRANCH=OISF/suricata-verify#2217
Changes since v8: