-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPDK rte_flow rules RSS support for more NICs - v1 #12315
Conversation
Move and adjust the base of RSS configuration from util-dpdk-i40e.c to a new file that can be later utilized by other cards. RSS configuration can be configured via rte_flow rules. This is useful for possible future features such as specific header offload (vxlan, nvgre) also implemented via rte_flow rules, as rte_flow rules can be chained via groups and priorities. Ticket: 7337
ixgbe driver requires different configuration of rss rte_flow rule than i40e, with just one generic rule matching all traffic. Ticket: 7337
ice driver has similar approach to setting rte_flow rss rule as i40e, only without explicitly setting queues. Ticket: 7337
mlx5 driver uses only one generic rte_flow rss rule to match all traffic Ticket: 7337
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see a bit more explanation in the commit messages about what these flow rules do. Right now it seems to expect quite in-depth knowledge to be able to understand them.
if (strcmp(driver_name, "net_i40e") == 0) | ||
i40eDeviceSetRSS(ptv->port_id, ptv->threads); | ||
i40eDeviceSetRSS(ptv->port_id, ptv->threads, ptv->livedev->dev); | ||
if (strcmp(driver_name, "net_ixgbe") == 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should be else if's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can change that.
Continues in #12317 |
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7337
Describe changes:
These changes were made for future support of more rte_flow rules (e.g. vxlan or nvgre header hardware offload) that can be chained on certain NICs via certain rte_flow attributes.
Ticket: #7337