Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doh2 65k limit 7464 v2 #12305

Closed
wants to merge 2 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7464

Describe changes:

  • doh2: really enforce 65K dns message limit

SV_BRANCH=OISF/suricata-verify#2197

#12294 with

  • SV test
  • new commit to add a missing entry in json schema as unveiled accidentally by the SV test
  • event split in 2 for both directions (to know which was the direction of the event)
  • stop processing further data if we should have reached the threshold

git grep js.set_string rust/src/http2/logger.rs | grep '"' |
cut -d'"' -f2 | sort | uniq | while read i;
do echo -n $i; git grep $i etc/schema.json | wc -l; done

shows only has_multiple was missing
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (master@2c0d3b8). Learn more about missing BASE report.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #12305   +/-   ##
=========================================
  Coverage          ?   79.56%           
=========================================
  Files             ?      912           
  Lines             ?   257455           
  Branches          ?        0           
=========================================
  Hits              ?   204847           
  Misses            ?    52608           
  Partials          ?        0           
Flag Coverage Δ
fuzzcorpus 61.09% <50.00%> (?)
livemode 19.39% <0.00%> (?)
pcap 44.40% <90.00%> (?)
unittests 59.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24013

@victorjulien victorjulien added this to the 8.0 milestone Dec 19, 2024
@victorjulien
Copy link
Member

Merged in #12314, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants