Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run CodeQL only on python changes #12298

Closed

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7358

Describe changes:

  • ci: run CodeQL only on python changes

#12151 taking the approach of duplicating the file because it is easier to have the check in on section than using strategy.matrix.exclude where it looks complex to have the list of different files

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@2c0d3b8). Learn more about missing BASE report.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #12298   +/-   ##
=========================================
  Coverage          ?   83.24%           
=========================================
  Files             ?      912           
  Lines             ?   257625           
  Branches          ?        0           
=========================================
  Hits              ?   214464           
  Misses            ?    43161           
  Partials          ?        0           
Flag Coverage Δ
fuzzcorpus 61.09% <ø> (?)
livemode 19.40% <ø> (?)
pcap 44.44% <ø> (?)
suricata-verify 62.86% <ø> (?)
unittests 59.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien
Copy link
Member

Not sure how to interpret the codeql warning.

@catenacyber
Copy link
Contributor Author

Not sure how to interpret the codeql warning.

Which one ?

@victorjulien
Copy link
Member

Not sure how to interpret the codeql warning.

Which one ?

See below
image

@catenacyber
Copy link
Contributor Author

Oh CodeQL says

Warning: Code scanning cannot determine the alerts introduced by this pull request, because 1 configuration present on refs/heads/master was not found: .github/workflows/codeql.yml:analyze/language:python

So, CodeQL says we analyzed python in master and we did not analyze it in this PR, so this may be dangerous

I think it is fine

@victorjulien victorjulien added this to the 8.0 milestone Dec 19, 2024
@victorjulien
Copy link
Member

Merged in #12314, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants