-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applayer plugin 5053 v3.15.1 #12234
Applayer plugin 5053 v3.15.1 #12234
Conversation
instead of a global variable. For easier initialization with dynamic number of protocols
for expectation_proto Ticket: 5053
for alproto_names Ticket: 5053
Ticket: 5053
so that we can use safely EXCEPTION_POLICY_MAX*sizeof(x)
Ticket: 5053 delay after initialization so that StringToAppProto works
Ticket: 5053
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12234 +/- ##
==========================================
- Coverage 83.19% 83.07% -0.12%
==========================================
Files 912 912
Lines 257166 268555 +11389
==========================================
+ Hits 213938 223101 +9163
- Misses 43228 45454 +2226
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: ERROR: QA failed on SURI_TLPR1_alerts_cmp.
Pipeline 23707 |
replaced by #12256 |
Information: QA ran without warnings. Pipeline 24007 |
Confused, why is there a v15 open as well as a v16? |
TL;DR v15.1 was a part of v16 I could have made a v16.1 which is v15.1 rebased, but not wasting resources As QA showed something interesting cf #12307 I am closing #12256 Let me know if
|
Rebased in #12352 |
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5053
Describe changes:
Let me know if I should split this PR
#12163 first commits, just making alprotos number dynamic, and not yet adding plugins support