-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add overview of *TriggerRawStreamReassembly #11446
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11446 +/- ##
==========================================
+ Coverage 82.44% 82.56% +0.12%
==========================================
Files 938 938
Lines 248068 248068
==========================================
+ Hits 204513 204816 +303
+ Misses 43555 43252 -303
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
Thanks for helping us all understand this better :)
As this is a draft, are you planning on adding an explanation on what does it mean to allow the detection engine to have access to a bigger portion of the raw stream?
doc/userguide/devguide/internals/engines/stream/applayertriggerrawreassembly.rst
Show resolved
Hide resolved
doc/userguide/devguide/internals/engines/stream/applayertriggerrawreassembly.rst
Show resolved
Hide resolved
doc/userguide/devguide/internals/engines/stream/applayertriggerrawreassembly.rst
Show resolved
Hide resolved
doc/userguide/devguide/internals/engines/stream/applayertriggerrawreassembly.rst
Show resolved
Hide resolved
doc/userguide/devguide/internals/engines/stream/applayertriggerrawreassembly.rst
Show resolved
Hide resolved
doc/userguide/devguide/internals/engines/stream/applayertriggerrawreassembly.rst
Show resolved
Hide resolved
I intended that to be shown with the diagram, could you please tell if something should be changed there or some text? |
I think that it's usually good to have a textual explanation of what the diagram illustrates (it may feel redundant, but considering that these concepts are complex and new to many; and people's learning abilities differ; I consider this makes docs more accessible :) ). |
Link to ticket: https://redmine.openinfosecfoundation.org/issues/4351
Apart from the content, looking for feedback on: