next/254/20240120/v1 #414
Closed
next/254/20240120/v1 #414
+122
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we fell back on HTTP/0.9 if there was a missing protocol except if the following line cintained a colon. This makes libhtp stricter to consider a transaction as 0.9 by only accepting if we have spaces after the request line as done in libhtp-rs Ticket: 6643
So that following headers and response still get processed Ticket: #6415
For instance, the following header may be considered as valid: Transfer-Encoding: chunked, chunked Introduces a new helper function to recognize header value tokens Ticket: #6415
|
@catenacyber how will cifuzz become green again if this is merged? |
Cifuzz is always green on the main branch, even if there are other known bugs (differential fuzzing findings) cf https://bugs.chromium.org/p/oss-fuzz/issues/list?q=label:Proj-libhtp |
lukashino
approved these changes
Jan 22, 2024
|
PR not against up to date 0.5.x |
Should I do something ? |
No, I need to rerun the staging but since we broken SV so we first need OISF/suricata-verify#1601 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging: