Feat/customization option for viewport notification #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev canceled.
|
|
Can you rebase on top of the new customization service and follow what's done there please? Sorry for the inconvenience |
|
do a |
@sedghi There was no changes found after running 'bun install'. Later installed playwright and run bun tests local then resolved playwright test issues, thank you. |
sedghi
reviewed
Jan 28, 2025
platform/docs/docs/platform/services/customization-service/sampleCustomizations.tsx
Outdated
Show resolved
Hide resolved
sedghi
reviewed
Jan 28, 2025
platform/core/src/services/UIViewportDialogService/UIViewportDialogService.ts
Outdated
Show resolved
Hide resolved
sedghi
reviewed
Jan 28, 2025
extensions/default/src/customizations/notificationCustomization.ts
Outdated
Show resolved
Hide resolved
sedghi
reviewed
Jan 28, 2025
extensions/cornerstone/src/Viewport/OHIFCornerstoneViewport.tsx
Outdated
Show resolved
Hide resolved
sedghi
requested changes
Jan 28, 2025
sedghi
reviewed
Jan 29, 2025
extensions/default/src/customizations/notificationCustomization.ts
Outdated
Show resolved
Hide resolved
sedghi
reviewed
Jan 29, 2025
extensions/cornerstone/src/Viewport/OHIFCornerstoneViewport.tsx
Outdated
Show resolved
Hide resolved
…pdated sample customization
nithin-trenser
force-pushed
the
feat/customization-option-for-viewport-notification
branch
from
738fc59 to
ba25242
Compare
|
let me know when this is ready for re-review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
An option has been implemented to allow for the customization of the viewport notification component. This enhancement enables users to tailor viewport notifications, thereby introducing a new component that improves user-friendliness (FlyWheel.io).
Changes & Results
Introduced a provision for displaying customized viewport notifications.
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment