trivial: add period#334
Open
wibeasley wants to merge 2 commits into
Open
Conversation
To make it consistent with the other parameters on this page. Even less important, I added "statement" to match some other parts of the page too.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #334 +/- ##
===========================================
- Coverage 56.36% 0.00% -56.37%
===========================================
Files 16 16
Lines 2725 2744 +19
===========================================
- Hits 1536 0 -1536
- Misses 1189 2744 +1555 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
In both of these cases, the SQL can contain one or more statements, so adding the word 'statement' (singular) seems unhelpful? |
Contributor
Author
|
Makes sense. I removed "statement" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make it consistent with the other parameters on this page. Even less important, I added "statement" to match some other parts of the page too.