Fix getCyclopsProfileLogLikelihood crashes when all slope values are NA#77
Open
azimov wants to merge 1 commit into
Open
Fix getCyclopsProfileLogLikelihood crashes when all slope values are NA#77azimov wants to merge 1 commit into
azimov wants to merge 1 commit into
Conversation
Member
|
The fact that we are now seeing NA values where before we only saw NaN and Inf (see code for handling that here) has me concerned. @azimov : could you provide a reproducible example so we can see where the NA values are coming from? The root cause of the NAs may be a bug elsewhere, which we'd better fix instead of adding a broad catchall like this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Issue #76