fix(execution): make ERA collapse ordering deterministic#36
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36 +/- ##
========================================
Coverage 85.79% 85.79%
========================================
Files 169 169
Lines 12514 12514
========================================
Hits 10737 10737
Misses 1777 1777 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
azimov
approved these changes
May 6, 2026
Collaborator
|
No issue with the fix - I've tested and confirmed this. I will create an issue for better testing to have higher visibility for more real cohorts between ibis and java implementations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes nondeterministic final ERA collapse in the Ibis execution engine.
The collapse window previously ordered only by
start_date. When multiple intervals had the same startdate, the backend could process the shorter interval before the longer one. That could leave a later
interval, fully contained by the longer interval, as an extra cohort row.
This change makes the collapse ordering deterministic by processing longer tied-start intervals first.
Minimal Reprex
Input intervals: