Skip to content

* reduce boilerplate in circe/execution/lower/* and normalize#31

Merged
azimov merged 3 commits into
developfrom
features/ibis-lowering-hooks
Apr 27, 2026
Merged

* reduce boilerplate in circe/execution/lower/* and normalize#31
azimov merged 3 commits into
developfrom
features/ibis-lowering-hooks

Conversation

@azimov
Copy link
Copy Markdown
Collaborator

@azimov azimov commented Mar 25, 2026

Resolves #20

* remove the hard-coded lowerer registry in lower/criteria.py
* clean up the Databricks workaround flow in circe/execution/databricks_compat.py
@azimov azimov requested a review from egillax March 25, 2026 00:51
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 98.37398% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.74%. Comparing base (c12ae6d) to head (611994a).

Files with missing lines Patch % Lines
circe/execution/databricks_compat.py 87.50% 1 Missing ⚠️
circe/extensions/waveform/lower.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #31      +/-   ##
===========================================
+ Coverage    85.71%   85.74%   +0.03%     
===========================================
  Files          166      168       +2     
  Lines        12315    12384      +69     
===========================================
+ Hits         10556    10619      +63     
- Misses        1759     1765       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@azimov azimov merged commit b29c26a into develop Apr 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant