Conversation
Cast datediff as bigint to prevent arithmetic overflow
turning off progress bar
trying to fix github actions
updating vignettes to try and pass actions
adding ubuntu latest as 20.04 depreciated
preparing for 2.1.4 release
putting examples in own directories
fixing example doc
using the new FE that fixes the Andromeda issue
adding failed case series csv test
changing version ready for release
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 86.99% 91.29% +4.30%
==========================================
Files 8 10 +2
Lines 1384 2688 +1304
==========================================
+ Hits 1204 2454 +1250
- Misses 180 234 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- changing aggregate csv to be done in batches - adding example results into testdata for testing the aggregate csv function
- changing append logic to only append if it is not the first time writing to the file or not the first chunk - adding more tests to the csv aggregation
Fix inconsistent PK designation in RDMS
- fixing progressBar to default to interactive() when possible or turned off when not possible to specify as an input. - added code to ensure all the result csv files are created
updating GHA with curl fix part 1 (thanks Anthony Sena!)
Update `row_count` to bigint
updating description and news for release
#fake table error
updating code that extracts ids in prepare for shiny to work with DatabaseConnector v7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before you do a pull request, you should always file an issue and make sure the package maintainer agrees that it’s a problem, and is happy with your basic proposal for fixing it. We don’t want you to spend a bunch of time on something that we don’t think is a good idea.
Additional requirements for pull requests:
Adhere to the Developer Guidelines as well as the OHDSI Code Style.
If possible, add unit tests for new functionality you add.
Restrict your pull request to solving the issue at hand. Do not try to 'improve' parts of the code that are not related to the issue. If you feel other parts of the code need better organization, create a separate issue for that.
Make sure you pass R check without errors and warnings before submitting.
Always target the
developbranch, and make sure you are up-to-date with the develop branch.